-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/30837: Add fallback value for name field #31898
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@allroundexperts Bump, could you help to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. One change I would like to see. cc @Beamanator since he's managing the issue.
@neil-marcellini I updated, please help to check again |
@DylanDylann please merge main to hopefully fix test (job 2) - see slack convo |
@Beamanator I updated |
Changes look good to me, @allroundexperts can you please test soon & complete the reviewer checklist? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks
@Beamanator Yep. Will finish this today! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeScreen.Recording.2023-12-04.at.2.43.19.AM.moviOS: NativeScreen.Recording.2023-12-04.at.2.40.34.AM.moviOS: mWeb SafariScreen.Recording.2023-12-04.at.2.38.43.AM.movMacOS: Chrome / SafariScreen.Recording.2023-12-04.at.2.31.02.AM.movMacOS: DesktopScreen.Recording.2023-12-04.at.2.35.49.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Beamanator @neil-marcellini 2 approval. Could you help to check again and merge this PR? Many thank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.8-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀
|
Details
We need to add value for name field instead of using undefined
Fixed Issues
$ #30837
PROPOSAL: #30837 (comment)
Tests
Same QA Step
Offline tests
Same QA step
QA Steps
Pre-condition: In offline, create and save 2 vague locations (eg-WT) for making distance request
1.Tap plus--request money-- distance
2.Enter start and finish point with any valid address
3. Edit the start point with the vague location in pre-condition
4. Verify that the new waypoint is updated with a error in the map
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2023-11-27.at.14.50.25-compressed.mov
Android: mWeb Chrome
Screen.Recording.2023-11-27.at.14.54.11-compressed.mov
iOS: Native
Screen.Recording.2023-11-27.at.14.49.22-compressed.mov
iOS: mWeb Safari
sa.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
Screen.Recording.2023-11-27.at.11.34.29.mov